Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 10440040: tar.gz the SDK if we're not on windows (Closed)

Created:
8 years, 7 months ago by sethladd
Modified:
8 years, 6 months ago
Reviewers:
dgrove
CC:
reviews_dartlang.org
Visibility:
Public.

Description

tar.gz the SDK if we're not on windows BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8077

Patch Set 1 #

Total comments: 1

Patch Set 2 : respect 80 chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M tools/upload_sdk.py View 1 3 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sethladd
Hi Dan, I wasn't sure how to test this, as this really wants to run ...
8 years, 7 months ago (2012-05-25 00:08:04 UTC) #1
dgrove
8 years, 6 months ago (2012-05-29 19:54:49 UTC) #2
lgtm

http://chromiumcodereview.appspot.com/10440040/diff/1/tools/upload_sdk.py
File tools/upload_sdk.py (right):

http://chromiumcodereview.appspot.com/10440040/diff/1/tools/upload_sdk.py#new...
tools/upload_sdk.py:94: sdk_file_targz = 'dart-%s-%s%s.tar.gz' %
(utils.GuessOS(), revision, sdk_suffix)
80 chars

Powered by Google App Engine
This is Rietveld 408576698