Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 10434008: Use most specific inferred type, or fall back to Dynamic (Closed)

Created:
8 years, 7 months ago by scheglov
Modified:
8 years, 7 months ago
Reviewers:
messick
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use most specific inferred type, or fall back to Dynamic R=messick@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -18 lines) Patch
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 3 chunks +37 lines, -8 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +27 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/completion/CompletionEngineTest.java View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 7 months ago (2012-05-23 22:33:30 UTC) #1
messick
8 years, 7 months ago (2012-05-23 23:18:06 UTC) #2
LGTM

Very nice.

Powered by Google App Engine
This is Rietveld 408576698