Issue 10434005: Disallow repeated formal parameters (issue 2240).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10434005: Disallow repeated formal parameters (issue 2240). (Closed)

Created:
8 years, 7 months ago by regis

Modified:
8 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disallow repeated formal parameters (issue 2240). Committed: https://code.google.com/p/dart/source/detail?r=7925

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	runtime/vm/parser.cc	View		1 chunk	+10 lines, -0 lines	1 comment	Download
	M	tests/co19/co19-runtime.status	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

lgtm https://chromiumcodereview.appspot.com/10434005/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/10434005/diff/1/runtime/vm/parser.cc#newcode1043 runtime/vm/parser.cc:1043: ErrorMsg(parameter.name_pos, "repeated formal parameter"); In other places we ...

8 years, 7 months ago (2012-05-23 21:34:39 UTC) #2

regis

8 years, 7 months ago (2012-05-23 22:30:24 UTC) #3

On 2012/05/23 21:34:39, hausner wrote:
> lgtm
> 
> https://chromiumcodereview.appspot.com/10434005/diff/1/runtime/vm/parser.cc
> File runtime/vm/parser.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10434005/diff/1/runtime/vm/parser.cc#n...
> runtime/vm/parser.cc:1043: ErrorMsg(parameter.name_pos, "repeated formal
> parameter");
> In other places we use the phrase "duplicate", so maybe the error should be
> "duplicate formal parameter name" ? You could even include the parameter name.

I submitted too early. I'll address yours comments in a following change.

Expand Messages | Collapse Messages