Issue 10421028: When methods cannot be optimized initialize their count to a large negative number, otherwise they …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10421028: When methods cannot be optimized initialize their count to a large negative number, otherwise they … (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

When methods cannot be optimized initialize their count to a large negative number, otherwise they keep calling the runtime. Committed: https://code.google.com/p/dart/source/detail?r=7969

Patch Set 2 : #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	runtime/vm/code_generator.cc	View		4 chunks	+4 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10421028/diff/3001/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://chromiumcodereview.appspot.com/10421028/diff/3001/runtime/vm/code_generator.cc#newcode1319 runtime/vm/code_generator.cc:1319: const intptr_t kLowInvocationCount = -100000000; Why this value ...

8 years, 7 months ago (2012-05-24 23:44:22 UTC) #3

srdjan

8 years, 7 months ago (2012-05-24 23:57:22 UTC) #4

https://chromiumcodereview.appspot.com/10421028/diff/3001/runtime/vm/code_gen...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/10421028/diff/3001/runtime/vm/code_gen...
runtime/vm/code_generator.cc:1319: const intptr_t kLowInvocationCount =
-100000000;
On 2012/05/24 23:44:22, asiva wrote:
> Why this value and not kIntptrMin....

It must be a Smi, could have been MinSmi but this number is as nice.

Expand Messages | Collapse Messages

Issue 10421028: When methods cannot be optimized initialize their count to a large negative number, otherwise they … (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages