Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Issue 10421026: Make pub handle missing git more gracefully. (Closed)

Created:
8 years, 7 months ago by Bob Nystrom
Modified:
8 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make pub handle missing git more gracefully. - Put in place the basics for reporting errors to the user. - If you try to install a git package without git installed, you will get a nice error. - Don't run git-related pub tests locally if the user doesn't have git installed. Committed: https://code.google.com/p/dart/source/detail?r=7959

Patch Set 1 #

Total comments: 8

Patch Set 2 : Respond to review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -56 lines) Patch
M utils/pub/command_install.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/pub/command_list.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M utils/pub/command_version.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/git_source.dart View 1 1 chunk +12 lines, -3 lines 0 comments Download
M utils/pub/io.dart View 2 chunks +38 lines, -0 lines 0 comments Download
M utils/pub/pub.dart View 1 2 chunks +36 lines, -6 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 2 chunks +38 lines, -36 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 4 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
This re-enables the git tests too. I'll check with Ivan once this goes in and ...
8 years, 7 months ago (2012-05-22 22:44:11 UTC) #1
nweiz
https://chromiumcodereview.appspot.com/10421026/diff/1/utils/pub/git_source.dart File utils/pub/git_source.dart (right): https://chromiumcodereview.appspot.com/10421026/diff/1/utils/pub/git_source.dart#newcode27 utils/pub/git_source.dart:27: return runProcess("git", ["clone", "--progress", id.description, destPath], Line length https://chromiumcodereview.appspot.com/10421026/diff/1/utils/pub/pub.dart ...
8 years, 7 months ago (2012-05-23 00:46:26 UTC) #2
Bob Nystrom
Thanks! https://chromiumcodereview.appspot.com/10421026/diff/1/utils/pub/git_source.dart File utils/pub/git_source.dart (right): https://chromiumcodereview.appspot.com/10421026/diff/1/utils/pub/git_source.dart#newcode27 utils/pub/git_source.dart:27: return runProcess("git", ["clone", "--progress", id.description, destPath], On 2012/05/23 ...
8 years, 7 months ago (2012-05-23 16:32:33 UTC) #3
nweiz
8 years, 7 months ago (2012-05-23 19:27:20 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698