Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 10417009: Reapply "Add support for timezone offset and timezone name." (Closed)

Created:
8 years, 7 months ago by floitsch
Modified:
8 years, 7 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Add support for timezone offset and timezone name." This reapplies commit 7800. Committed: https://code.google.com/p/dart/source/detail?r=7805

Patch Set 1 #

Patch Set 2 : Next try. #

Patch Set 3 : Add missing semicolon. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -0 lines) Patch
M corelib/src/date.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M frog/lib/date_implementation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M lib/compiler/implementation/lib/mockimpl.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/lib/date.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/lib/date.dart View 2 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/os.h View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/os_win.cc View 1 2 2 chunks +49 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/corelib/date_time7_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
8 years, 7 months ago (2012-05-21 15:59:34 UTC) #1
floitsch
TBR since the CL was already reviewed several times ;)
8 years, 7 months ago (2012-05-21 16:10:26 UTC) #2
Mads Ager (google)
8 years, 7 months ago (2012-05-22 06:03:20 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698