Issue 10416015: Revert 7788. These tests were marked as fail/flaky with no further action to be

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10416015: Revert 7788. These tests were marked as fail/flaky with no further action to be (Closed)

Created:
8 years, 7 months ago by Emily Fortuna

Modified:
8 years, 7 months ago

Reviewers:
vsm, Anton Muhin, ngeoffray

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert 7788. These tests were marked as fail/flaky with no further action to be taken on them, when in reality they are all passing with the latest Chrome/DRT rolled update. Please don't change status files arbitrarily. Committed: https://code.google.com/p/dart/source/detail?r=7819

Patch Set 1 : #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -4 lines)			Patch
M	samples/tests/samples/samples.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	tests/dom/dom.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/html.status	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Here's the CL we're reverting: https://chromiumcodereview.appspot.com/10417005/ The latest tip-of-tree Chrome fixed those failures we were ...

8 years, 7 months ago (2012-05-21 20:05:09 UTC) #1

vsm

LGTM! Thanks, Emily. So - the tests started failing on one Chrome/DRT update and starting ...

8 years, 7 months ago (2012-05-21 20:08:39 UTC) #2

ngeoffray

8 years, 7 months ago (2012-05-22 08:38:31 UTC) #3

Hi Emily,

As you noticed, it was not arbitrarily that I changed these status files. Please
don't assume so. Also note that swarm_test now passes with no apparent reason:

http://build.chromium.org/p/client.dart/builders/web-chrome-linux/builds/2258...

Expand Messages | Collapse Messages