Issue 10414084: Replace linked list of loaded libraries

Issue 10414084: Replace linked list of loaded libraries (Closed)

Created:
8 years, 7 months ago by hausner

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Replace linked list of loaded libraries Replace the linked list of loaded libraries with a growable array or libraries in the object store. This array will be used in the debugger, where we use the index of a library in the array as an id number, similarly to the class id and the table of loaded classes. Committed: https://code.google.com/p/dart/source/detail?r=7923

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -53 lines)			Patch
M	runtime/vm/code_generator_test.cc	View	1 2 3	1 chunk	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 2 3	1 chunk	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1 2 3	1 chunk	+8 lines, -13 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	7 chunks	+42 lines, -18 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1 2 3	2 chunks	+6 lines, -7 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM http://codereview.chromium.org/10414084/diff/7002/runtime/vm/code_generator_test.cc File runtime/vm/code_generator_test.cc (right): http://codereview.chromium.org/10414084/diff/7002/runtime/vm/code_generator_test.cc#newcode496 runtime/vm/code_generator_test.cc:496: const Library& app_lib = Library::CheckedHandle(libs.At(num_libs - 1)); Why ...

8 years, 7 months ago (2012-05-23 17:35:18 UTC) #2

hausner

8 years, 7 months ago (2012-05-23 20:27:14 UTC) #3

http://codereview.chromium.org/10414084/diff/7002/runtime/vm/code_generator_t...
File runtime/vm/code_generator_test.cc (right):

http://codereview.chromium.org/10414084/diff/7002/runtime/vm/code_generator_t...
runtime/vm/code_generator_test.cc:496: const Library& app_lib =
Library::CheckedHandle(libs.At(num_libs - 1));
On 2012/05/23 17:35:18, srdjan wrote:
> Why checked handle? Shouldn't it be ^= instead

Done.

http://codereview.chromium.org/10414084/diff/7002/runtime/vm/debugger_api_imp...
File runtime/vm/debugger_api_impl.cc (right):

http://codereview.chromium.org/10414084/diff/7002/runtime/vm/debugger_api_imp...
runtime/vm/debugger_api_impl.cc:508: const Array& library_list =
Array::Handle(Array::New(num_libs));
On 2012/05/23 17:35:18, srdjan wrote:
> library_url_list ?

Done.

http://codereview.chromium.org/10414084/diff/7002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/10414084/diff/7002/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:5502: const Library& lib =
Library::CheckedHandle(libs.At(index));
On 2012/05/23 17:35:18, srdjan wrote:
> Should be ^=

Done.

Expand Messages | Collapse Messages