Support for cookies in the HTTP library

Support for cookies in the HTTP library

This change adds the list field cookies to all requests and
responses.

For HttpRequest the cookie list will have all the cookies set by
the client in its HttpClientRequest cookie list. These cookies
are passed through the "Cookie" HTTP header.

For HttpClientResponse the cookie list will have all the cookies
set by the server in the HttpResponse cookie list. These cookies
are passed through the "Set-Cookie" HTTP header.

The parsing of the "Cookie" and "Set-Cookie" headers try to
follow RFC 6265.

This change does not add a cookie jar in the http client with
cookie policy for automatic cookie handling.

R=ager@google.com, ajohnsen@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=7943

[Mads Ager (google), 2012-05-23 13:31:05]

Minor comments and a question about isValid

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:280: * Indicate that for the header named [name] don't
apply the folding
I found this comment hard to read. Maybe something like:

Disable folding for the header named [name]. For most headers, multiple header
values are folded into a single header field by separating the values with
commas. The Set-Cookie header has folding disabled by default.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:432: * and when receiving cookies by the client as
Set-Cookie header all
by the client -> in the client?

as Set-Cookie header -> as Set-Cookie headers

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:453: * Gets and sets the name.
the value

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:486: 
Remove empty line.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:490: * Returns the formatted string representation of the
cookie for
Returns the formatted string representation of the cookie. The string
representation can be used for ...

?

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:442: _Cookie([String this.name, String this.value]);
I would add a blank line after the first constructor.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:561: bool isValid() => _valid;
I did not notice this in the interface. Add it? Should this be a getter? bool
get valid;

Also, since these are mutable shouldn't this be doing more? What if the name is
set to "" or to 42 after this Cookie was created? It will still say that it is
valid. It seems that could be an issue?

Do we need to verify here on each call?

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:751: if (s[index] != " " && s[index] != "\t") return;
indentation

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:766: int start = index;
indentation

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:775: if (done()) throw new HttpException("Failed to
parse header value [$s]");
Long line.

https://chromiumcodereview.appspot.com/10414076/diff/1/tests/standalone/io/ht...
File tests/standalone/io/http_test.dart (right):

https://chromiumcodereview.appspot.com/10414076/diff/1/tests/standalone/io/ht...
tests/standalone/io/http_test.dart:634: 
Delete empty line

[Søren Gjesse, 2012-05-24 11:34:21]

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:280: * Indicate that for the header named [name] don't
apply the folding
On 2012/05/23 13:31:05, Mads Ager wrote:
> I found this comment hard to read. Maybe something like:
> 
> Disable folding for the header named [name]. For most headers, multiple header
> values are folded into a single header field by separating the values with
> commas. The Set-Cookie header has folding disabled by default.

Done.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:432: * and when receiving cookies by the client as
Set-Cookie header all
On 2012/05/23 13:31:05, Mads Ager wrote:
> by the client -> in the client?
> 
> as Set-Cookie header -> as Set-Cookie headers

Done.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:453: * Gets and sets the name.
On 2012/05/23 13:31:05, Mads Ager wrote:
> the value

Done.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:486: 
On 2012/05/23 13:31:05, Mads Ager wrote:
> Remove empty line.

Done.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:490: * Returns the formatted string representation of the
cookie for
On 2012/05/23 13:31:05, Mads Ager wrote:
> Returns the formatted string representation of the cookie. The string
> representation can be used for ...
> 
> ?

Done.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:442: _Cookie([String this.name, String this.value]);
On 2012/05/23 13:31:05, Mads Ager wrote:
> I would add a blank line after the first constructor.

Done.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:561: bool isValid() => _valid;
On 2012/05/23 13:31:05, Mads Ager wrote:
> I did not notice this in the interface. Add it? Should this be a getter? bool
> get valid;
> 
> Also, since these are mutable shouldn't this be doing more? What if the name
is
> set to "" or to 42 after this Cookie was created? It will still say that it is
> valid. It seems that could be an issue?
> 
> Do we need to verify here on each call?

This was intended for handling validity when constructing from a string
(constructor fromSetCookitValue) but I ended up throwing exceptions instead.
When building a cookie there are no real validation needed.

I removed this for now as it was not used after all.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:751: if (s[index] != " " && s[index] != "\t") return;
On 2012/05/23 13:31:05, Mads Ager wrote:
> indentation

Done.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:766: int start = index;
On 2012/05/23 13:31:05, Mads Ager wrote:
> indentation

Done.

https://chromiumcodereview.appspot.com/10414076/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:775: if (done()) throw new HttpException("Failed to
parse header value [$s]");
On 2012/05/23 13:31:05, Mads Ager wrote:
> Long line.

Done.

https://chromiumcodereview.appspot.com/10414076/diff/1/tests/standalone/io/ht...
File tests/standalone/io/http_test.dart (right):

https://chromiumcodereview.appspot.com/10414076/diff/1/tests/standalone/io/ht...
tests/standalone/io/http_test.dart:634: 
On 2012/05/23 13:31:05, Mads Ager wrote:
> Delete empty line

Done.

[Mads Ager (google), 2012-05-24 11:42:35]

LGTM except for use of _valid field.

https://chromiumcodereview.appspot.com/10414076/diff/7001/runtime/bin/http_im...
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10414076/diff/7001/runtime/bin/http_im...
runtime/bin/http_impl.dart:526: _valid = false;
_valid no longer exists - throw exception and add a test case?

[Søren Gjesse, 2012-05-24 12:54:25]

https://chromiumcodereview.appspot.com/10414076/diff/7001/runtime/bin/http_im...
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10414076/diff/7001/runtime/bin/http_im...
runtime/bin/http_impl.dart:526: _valid = false;
On 2012/05/24 11:42:35, Mads Ager wrote:
> _valid no longer exists - throw exception and add a test case?

Done.