Issue 10414046: Add support for directory renaming to dart:io.

Issue 10414046: Add support for directory renaming to dart:io. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)

Modified:
8 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for directory renaming to dart:io. R=sgjesse@google.com BUG=dartbug:3104 TEST=standalone/io/directory* Committed: https://code.google.com/p/dart/source/detail?r=7848

Patch Set 2 : Address review comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+205 lines, -52 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/directory.h	View		1 chunk	+5 lines, -7 lines	0 comments	Download
M	runtime/bin/directory.cc	View		6 chunks	+38 lines, -12 lines	0 comments	Download
M	runtime/bin/directory.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	runtime/bin/directory_impl.dart	View		8 chunks	+44 lines, -33 lines	0 comments	Download
M	runtime/bin/directory_posix.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	tests/standalone/io/directory_error_test.dart	View	1	2 chunks	+53 lines, -0 lines	0 comments	Download
M	tests/standalone/io/directory_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/10414046/diff/1/tests/standalone/io/directory_error_test.dart File tests/standalone/io/directory_error_test.dart (right): https://chromiumcodereview.appspot.com/10414046/diff/1/tests/standalone/io/directory_error_test.dart#newcode197 tests/standalone/io/directory_error_test.dart:197: void testRenameFile(Directory temp, Function done) { Maybe add ...

8 years, 7 months ago (2012-05-22 12:42:42 UTC) #2

Mads Ager (google)

8 years, 7 months ago (2012-05-22 12:46:10 UTC) #3

https://chromiumcodereview.appspot.com/10414046/diff/1/tests/standalone/io/di...
File tests/standalone/io/directory_error_test.dart (right):

https://chromiumcodereview.appspot.com/10414046/diff/1/tests/standalone/io/di...
tests/standalone/io/directory_error_test.dart:197: void testRenameFile(Directory
temp, Function done) {
On 2012/05/22 12:42:42, Søren Gjesse wrote:
> Maybe add AsDirectory or something like that to the name here.

Done.

https://chromiumcodereview.appspot.com/10414046/diff/1/tests/standalone/io/di...
tests/standalone/io/directory_error_test.dart:205: renameDone.then((ignore) =>
Expect.fail('rename non existent'));
On 2012/05/22 12:42:42, Søren Gjesse wrote:
> rename non existent -> rename file as directory

Done.

Expand Messages | Collapse Messages