Issue 10414024: Add a flag to control the backend.

Issue 10414024: Add a flag to control the backend. (Closed)

Created:
8 years, 7 months ago by Anton Muhin

Modified:
8 years, 7 months ago

Reviewers:
ahe, floitsch, ngeoffray, kasperl, Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a flag to control the backend. R=ahe@google.com,floitsch@google.com,kasperl@google.com,ngeoffray@google.com,smok@google.com

Patch Set 3 : Next iteration #

Total comments: 4

Patch Set 4 : Last version #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
M	lib/compiler/implementation/apiimpl.dart	View	1 2 3	1 chunk	+6 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View	1 2 3	4 chunks	+10 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/dart2js.dart	View	1 2 3	2 chunks	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

Rework per Peter's suggestion https://chromiumcodereview.appspot.com/10414024/diff/4001/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (left): https://chromiumcodereview.appspot.com/10414024/diff/4001/lib/compiler/implementation/compiler.dart#oldcode152 lib/compiler/implementation/compiler.dart:152: backend = new JavaScriptBackend(this); I ...

8 years, 7 months ago (2012-05-21 15:22:07 UTC) #2

ahe

LGTM with comments. https://chromiumcodereview.appspot.com/10414024/diff/4001/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (left): https://chromiumcodereview.appspot.com/10414024/diff/4001/lib/compiler/implementation/compiler.dart#oldcode152 lib/compiler/implementation/compiler.dart:152: backend = new JavaScriptBackend(this); On 2012/05/21 ...

8 years, 7 months ago (2012-05-21 15:38:50 UTC) #3

ahe

8 years, 7 months ago (2012-05-22 10:36:07 UTC) #4

https://chromiumcodereview.appspot.com/10414024/diff/6002/lib/compiler/implem...
File lib/compiler/implementation/dart2js.dart (right):

https://chromiumcodereview.appspot.com/10414024/diff/6002/lib/compiler/implem...
lib/compiler/implementation/dart2js.dart:243: Output either JavaScript code (if
value is 'js') or Dart code (if value is 'dart').
FYI: long line (please stay below 80 characters in the future).

I'm editing this message and noticed it, and I'll fix it.

Expand Messages | Collapse Messages