Issue 10414021: Reland: Add more API fuzzing and fix the issues encountered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10414021: Reland: Add more API fuzzing and fix the issues encountered. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)

Modified:
8 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reland: Add more API fuzzing and fix the issues encountered. Only change from original code review is the closing of files opened in the test. - Fixed integer checks in a couple of places. - Added closed checks to async operations. More changes like this coming but I'm splitting the work up to not make the review too large. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7790

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+298 lines, -199 lines)			Patch
M	runtime/bin/builtin_natives.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/bin/dartutils.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file.cc	View	28 chunks	+152 lines, -182 lines	0 comments	Download
M	runtime/bin/file_impl.dart	View	14 chunks	+24 lines, -13 lines	0 comments	Download
M	runtime/bin/string_stream.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	tests/standalone/io/file_fuzz_test.dart	View	3 chunks	+97 lines, -2 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages