Issue 10414005: Remove script source from the snapshot in order to reduce the size and to make the image size small…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10414005: Remove script source from the snapshot in order to reduce the size and to make the image size small… (Closed)

Created:
8 years, 7 months ago by siva

Modified:
8 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Remove script source from the snapshot in order to reduce the size and to make the image size smaller. When the source for a script is needed we regenerate the source (a close approximation). The size of the core isolate snapshot (corelibs, builtin, io etc.) prior to this change is 1438238 bytes and after the change it is 769026 bytes. The CorelibIsolateStartup times goes from 5389 microseconds to 4843 microseconds. Committed: https://code.google.com/p/dart/source/detail?r=7774

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -9 lines)			Patch
M	vm/object.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	vm/object.cc	View	1 2	2 chunks	+32 lines, -0 lines	0 comments	Download
M	vm/raw_object_snapshot.cc	View	1 2	2 chunks	+9 lines, -6 lines	0 comments	Download
M	vm/snapshot_test.cc	View	1 2	2 chunks	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

Pretty ingeniously simple! I think we should consider making newline characters in the source a ...

8 years, 7 months ago (2012-05-18 21:14:34 UTC) #2

siva

8 years, 7 months ago (2012-05-18 22:23:01 UTC) #4

Thanks for the review.

Agree, we should do a trade off analysis between the increase in token stream
space Versus time saved while computing line numbers.

http://codereview.chromium.org/10414005/diff/2002/vm/snapshot_test.cc
File vm/snapshot_test.cc (right):

http://codereview.chromium.org/10414005/diff/2002/vm/snapshot_test.cc#newcode764
vm/snapshot_test.cc:764: // rescan this source and compare the token stream to
see if they are
On 2012/05/18 21:14:34, hausner wrote:
> New sentence? 

Done.

Expand Messages | Collapse Messages