Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 10413031: Reapply "Add support for timezone offset and timezone name." (Closed)

Created:
8 years, 7 months ago by floitsch
Modified:
8 years, 7 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Add support for timezone offset and timezone name." This reapplies commit 7800. Original CL: https://chromiumcodereview.appspot.com/10383218/ Don't write *foo += x. Committed: https://code.google.com/p/dart/source/detail?r=7803

Patch Set 1 #

Patch Set 2 : Update status file. #

Total comments: 2

Patch Set 3 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -0 lines) Patch
M corelib/src/date.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M frog/lib/date_implementation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M lib/compiler/implementation/lib/mockimpl.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/lib/date.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/lib/date.dart View 2 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/os.h View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/os_win.cc View 2 chunks +49 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A tests/corelib/date_time7_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
8 years, 7 months ago (2012-05-21 14:49:10 UTC) #1
floitsch
Forgot to upload before the fix. The only line that changed was os_win.cc:100.
8 years, 7 months ago (2012-05-21 14:49:39 UTC) #2
floitsch
There is still something else broken. Will fix that right away and then inform you ...
8 years, 7 months ago (2012-05-21 14:53:09 UTC) #3
floitsch
Updated status file for frog.
8 years, 7 months ago (2012-05-21 14:59:14 UTC) #4
Mads Ager (google)
lgtm https://chromiumcodereview.appspot.com/10413031/diff/2002/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://chromiumcodereview.appspot.com/10413031/diff/2002/tests/corelib/corelib.status#newcode37 tests/corelib/corelib.status:37: date_time7_test: Skip # New methods (timeZoneName and timeZoneOffset) ...
8 years, 7 months ago (2012-05-21 15:02:55 UTC) #5
floitsch
8 years, 7 months ago (2012-05-21 15:06:32 UTC) #6
https://chromiumcodereview.appspot.com/10413031/diff/2002/tests/corelib/corel...
File tests/corelib/corelib.status (right):

https://chromiumcodereview.appspot.com/10413031/diff/2002/tests/corelib/corel...
tests/corelib/corelib.status:37: date_time7_test: Skip  # New methods
(timeZoneName and timeZoneOffset) were not ported to frog.
On 2012/05/21 15:02:55, Mads Ager wrote:
> Use two lines for the comment?

Moved the comment before the Skip line.

Powered by Google App Engine
This is Rietveld 408576698