aChange all asyncTest/callbackDone style tests to use the new expectAsync/

Change asyncTest/callbackDone style tests to use the new expectAsync/
guardAsync form, and fix a couple of issues in the unit test library
related to these.
Note: this CL covers the changes in the tests directory. There are a few
changes in utils and samples; these will de done in a separate CL.
Committed: https://code.google.com/p/dart/source/detail?r=7877

[Siggi Cherem (dart-lang), 2012-05-21 22:20:47]

https://chromiumcodereview.appspot.com/10412015/diff/5001/lib/unittest/unitte...
File lib/unittest/unittest.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/lib/unittest/unitte...
lib/unittest/unittest.dart:414: // that is recursively invoked in the case of
async tests.
can we clarify here why recursive calls happen. In particular, if callbacks are
invoked asynchronously, nothing bad happens. Bad things happen when a test is
written in an asynchronous fashion, but the code runs sychronously.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/async_win...
File tests/dom/async_window_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/async_win...
tests/dom/async_window_test.dart:14: id = window.setInterval(() {
we should add here an expectAsync0 with count: 3.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
File tests/dom/indexeddb_3_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
tests/dom/indexeddb_3_test.dart:70: cursorRequest.addEventListener("success",
(e) {
this is one you could do without the 'doneCallback'. Since you expect this to
run 100 times (see itemCount) you could wrap it here with expectAsync1((e)
{...}, count: 100)

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
tests/dom/indexeddb_3_test.dart:100: cursorRequest.addEventListener("success",
(e) {
same here

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
File tests/dom/indexeddb_4_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
tests/dom/indexeddb_4_test.dart:30: expectAsync1( (e) {
remove extra space ( (

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
tests/dom/indexeddb_4_test.dart:48: expectAsync1( (e) { writeItems(index + 1);
}));
ditto

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
tests/dom/indexeddb_4_test.dart:66: var doneCallback = expectAsync0((){});
here also you could do without doneCallback:
expectAsync1((e) {...},
    count: expectedFirst == null ? 0 : expectedLast - expectedFirst + 1);

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/isolates_...
File tests/dom/isolates_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/isolates_...
tests/dom/isolates_test.dart:38: new
PingPongIsolate().spawn().then((isolate.SendPort port) {
=> expectAsync1 (and remove 'callback')

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/isolates_...
tests/dom/isolates_test.dart:43: var callback = expectAsync0((){});
same here. (basically expectAsync1 on every 'then' call)?

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/request_a...
File tests/dom/request_animation_frame_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/request_a...
tests/dom/request_animation_frame_test.dart:24: //Expect.isTrue(timestamp2 >
timestamp1, 'timestamps ordered');
would you mind fixing this 80 col here?

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/async_wi...
File tests/html/async_window_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/async_wi...
tests/html/async_window_test.dart:15: id = window.setInterval(() {
here also: count:3, get rid of 'callback'

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/async_wi...
tests/html/async_window_test.dart:28: });}, 10);
wrap after ;?

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/async_wi...
tests/html/async_window_test.dart:28: });}, 10);
wrap after ;?

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
File tests/html/indexeddb_2_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
tests/html/indexeddb_2_test.dart:35: expectAsync1((e) {
style-nit: I'd keep the expectAsync1((e) { in the previous line.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
File tests/html/indexeddb_3_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
tests/html/indexeddb_3_test.dart:47: expectAsync1((e) {
remove tab, possibly merge with prev line

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
tests/html/indexeddb_3_test.dart:69: cursorRequest.on.success.add((e) {
replace doneCallback with count:100 here and below.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
File tests/html/indexeddb_4_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
tests/html/indexeddb_4_test.dart:62: var doneCallback = expectAsync0((){});
ditto

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/isolates...
File tests/html/isolates_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/isolates...
tests/html/isolates_test.dart:37: var callback = expectAsync0((){});
you can probably get this to work with expectAsync1 as a callback to 'then'
without using 'callback'.
(same below)

[gram, 2012-05-22 17:36:36]

https://chromiumcodereview.appspot.com/10412015/diff/5001/lib/unittest/unitte...
File lib/unittest/unittest.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/lib/unittest/unitte...
lib/unittest/unittest.dart:414: // that is recursively invoked in the case of
async tests.
On 2012/05/21 22:20:47, sigmund wrote:
> can we clarify here why recursive calls happen. In particular, if callbacks
are
> invoked asynchronously, nothing bad happens. Bad things happen when a test is
> written in an asynchronous fashion, but the code runs sychronously.

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/async_win...
File tests/dom/async_window_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/async_win...
tests/dom/async_window_test.dart:14: id = window.setInterval(() {
On 2012/05/21 22:20:47, sigmund wrote:
> we should add here an expectAsync0 with count: 3.

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
File tests/dom/indexeddb_3_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
tests/dom/indexeddb_3_test.dart:70: cursorRequest.addEventListener("success",
(e) {
On 2012/05/21 22:20:47, sigmund wrote:
> this is one you could do without the 'doneCallback'. Since you expect this to
> run 100 times (see itemCount) you could wrap it here with expectAsync1((e)
> {...}, count: 100)

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
tests/dom/indexeddb_3_test.dart:100: cursorRequest.addEventListener("success",
(e) {
On 2012/05/21 22:20:47, sigmund wrote:
> same here

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
File tests/dom/indexeddb_4_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
tests/dom/indexeddb_4_test.dart:30: expectAsync1( (e) {
On 2012/05/21 22:20:47, sigmund wrote:
> remove extra space ( (

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
tests/dom/indexeddb_4_test.dart:48: expectAsync1( (e) { writeItems(index + 1);
}));
On 2012/05/21 22:20:47, sigmund wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/indexeddb...
tests/dom/indexeddb_4_test.dart:66: var doneCallback = expectAsync0((){});
On 2012/05/21 22:20:47, sigmund wrote:
> here also you could do without doneCallback:
> expectAsync1((e) {...},
>     count: expectedFirst == null ? 0 : expectedLast - expectedFirst + 1);

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/isolates_...
File tests/dom/isolates_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/isolates_...
tests/dom/isolates_test.dart:38: new
PingPongIsolate().spawn().then((isolate.SendPort port) {
On 2012/05/21 22:20:47, sigmund wrote:
> => expectAsync1 (and remove 'callback')

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/isolates_...
tests/dom/isolates_test.dart:43: var callback = expectAsync0((){});
On 2012/05/21 22:20:47, sigmund wrote:
> same here. (basically expectAsync1 on every 'then' call)?

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/request_a...
File tests/dom/request_animation_frame_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/dom/request_a...
tests/dom/request_animation_frame_test.dart:24: //Expect.isTrue(timestamp2 >
timestamp1, 'timestamps ordered');
On 2012/05/21 22:20:47, sigmund wrote:
> would you mind fixing this 80 col here?

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/async_wi...
File tests/html/async_window_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/async_wi...
tests/html/async_window_test.dart:15: id = window.setInterval(() {
On 2012/05/21 22:20:47, sigmund wrote:
> here also: count:3, get rid of 'callback'

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/async_wi...
tests/html/async_window_test.dart:28: });}, 10);
On 2012/05/21 22:20:47, sigmund wrote:
> wrap after ;?

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/async_wi...
tests/html/async_window_test.dart:28: });}, 10);
On 2012/05/21 22:20:47, sigmund wrote:
> wrap after ;?

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
File tests/html/indexeddb_2_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
tests/html/indexeddb_2_test.dart:35: expectAsync1((e) {
On 2012/05/21 22:20:47, sigmund wrote:
> style-nit: I'd keep the expectAsync1((e) { in the previous line.

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
File tests/html/indexeddb_3_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
tests/html/indexeddb_3_test.dart:47: expectAsync1((e) {
On 2012/05/21 22:20:47, sigmund wrote:
> remove tab, possibly merge with prev line

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
tests/html/indexeddb_3_test.dart:69: cursorRequest.on.success.add((e) {
On 2012/05/21 22:20:47, sigmund wrote:
> replace doneCallback with count:100 here and below.

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
File tests/html/indexeddb_4_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/indexedd...
tests/html/indexeddb_4_test.dart:62: var doneCallback = expectAsync0((){});
On 2012/05/21 22:20:47, sigmund wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/isolates...
File tests/html/isolates_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/5001/tests/html/isolates...
tests/html/isolates_test.dart:37: var callback = expectAsync0((){});
On 2012/05/21 22:20:47, sigmund wrote:
> you can probably get this to work with expectAsync1 as a callback to 'then'
> without using 'callback'.
> (same below)

Done.

[Siggi Cherem (dart-lang), 2012-05-22 19:50:15]

lgtm!... after addressing the comment below :-)

https://chromiumcodereview.appspot.com/10412015/diff/3036/tests/dom/async_win...
File tests/dom/async_window_test.dart (right):

https://chromiumcodereview.appspot.com/10412015/diff/3036/tests/dom/async_win...
tests/dom/async_window_test.dart:26: }, 3), 10);
style: add 'count: ' in front of 3 (since this is an optional argument, we
specify it with it's name)

Here and elsewhere in the CL