Issue 10411053: Finish file 'fuzzer' and fix issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10411053: Finish file 'fuzzer' and fix issues. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)

Modified:
8 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Finish file 'fuzzer' and fix issues. - One integer extraction issue. - Changed to using nativeport.call().transform to make sure that exceptions during the processing of the reply are propagated to the future. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7843

Patch Set 1 #

Patch Set 2 : Remove 'else' parts #

Patch Set 3 : Fix typo #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -141 lines)			Patch
M	runtime/bin/dartutils.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/bin/file.cc	View		3 chunks	+19 lines, -5 lines	0 comments	Download
M	runtime/bin/file_impl.dart	View	1 2	18 chunks	+84 lines, -134 lines	0 comments	Download
M	tests/standalone/io/file_fuzz_test.dart	View		3 chunks	+35 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages