Fix issue 2756 where '$' has as special meaning in Javascript String.replace.

Fix issue 2756 where '$' has as special meaning in Javascript String.replace.
Committed: https://code.google.com/p/dart/source/detail?r=7787

[floitsch, 2012-05-21 08:49:15]

LGTM.

https://chromiumcodereview.appspot.com/10411048/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/string_helper.dart (right):

https://chromiumcodereview.appspot.com/10411048/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/string_helper.dart:93: to = JS('String',
@"#.replace('\$', '$$$$')", to);
Add comment explaining why you need 4 '$'.
Also I don't think you need to escape the first '$' (in the from string).

[ngeoffray, 2012-05-21 10:14:57]

Thanks Florian. I have also updated all the places where we use JS
String.replace.

https://chromiumcodereview.appspot.com/10411048/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/string_helper.dart (right):

https://chromiumcodereview.appspot.com/10411048/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/string_helper.dart:93: to = JS('String',
@"#.replace('\$', '$$$$')", to);
On 2012/05/21 08:49:15, floitsch wrote:
> Add comment explaining why you need 4 '$'.
> Also I don't think you need to escape the first '$' (in the from string).

Done.

[ahe, 2012-05-21 10:20:06]

LGTM