Issue 10409067: More inlined type checking for x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10409067: More inlined type checking for x64. (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More inlined type checking for x64. Committed: https://code.google.com/p/dart/source/detail?r=7867

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -14 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2	6 chunks	+136 lines, -9 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	2 chunks	+25 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10409067/diff/4001/runtime/vm/flow_graph_compiler_x64.cc File runtime/vm/flow_graph_compiler_x64.cc (right): https://chromiumcodereview.appspot.com/10409067/diff/4001/runtime/vm/flow_graph_compiler_x64.cc#newcode148 runtime/vm/flow_graph_compiler_x64.cc:148: if (tp_argument.IsMalformed()) { You can assert that it ...

8 years, 7 months ago (2012-05-22 18:07:51 UTC) #2

srdjan

8 years, 7 months ago (2012-05-22 18:23:57 UTC) #4

https://chromiumcodereview.appspot.com/10409067/diff/4001/runtime/vm/flow_gra...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://chromiumcodereview.appspot.com/10409067/diff/4001/runtime/vm/flow_gra...
runtime/vm/flow_graph_compiler_x64.cc:148: if (tp_argument.IsMalformed()) {
On 2012/05/22 18:07:51, regis wrote:
> You can assert that it is not malformed. My pending cl should guarantee that.

Done.

Expand Messages | Collapse Messages

Issue 10409067: More inlined type checking for x64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages