Issue 10408087: Parameterize the native_handler with the world/enqueuer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408087: Parameterize the native_handler with the world/enqueuer. (Closed)

Created:
8 years, 7 months ago by ahe

Modified:
8 years, 7 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Parameterize the native_handler with the world/enqueuer. Committed: https://code.google.com/p/dart/source/detail?r=7907

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -20 lines)			Patch
	M	dart/lib/compiler/implementation/compiler.dart	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
	M	dart/lib/compiler/implementation/native_handler.dart	View		4 chunks	+14 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://chromiumcodereview.appspot.com/10408087/diff/1/dart/lib/compiler/implementation/compiler.dart File dart/lib/compiler/implementation/compiler.dart (right): https://chromiumcodereview.appspot.com/10408087/diff/1/dart/lib/compiler/implementation/compiler.dart#newcode196 dart/lib/compiler/implementation/compiler.dart:196: MessageKind.COMPILER_CRASHED.error().toString(), Why is this necessary?

8 years, 7 months ago (2012-05-23 14:03:36 UTC) #3

ahe

8 years, 7 months ago (2012-05-23 14:24:32 UTC) #4

Thank you both for taking a look.

https://chromiumcodereview.appspot.com/10408087/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/10408087/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/compiler.dart:196:
MessageKind.COMPILER_CRASHED.error().toString(),
On 2012/05/23 14:03:36, karlklose wrote:
> Why is this necessary?

Because reportDiagnostic takes a String.

https://chromiumcodereview.appspot.com/10408087/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/compiler.dart:200:
print(MessageKind.PLEASE_REPORT_THE_CRASH.message([buildId]).toString());
Not necessary, though.

Expand Messages | Collapse Messages

Issue 10408087: Parameterize the native_handler with the world/enqueuer. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages