Issue 10408075: Run dart2js compiled Dromaeo on Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408075: Run dart2js compiled Dromaeo on Chrome (Closed)

Created:
8 years, 7 months ago by vsm

Modified:
8 years, 7 months ago

Reviewers:
Emily Fortuna, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Run dart2js compiled Dromaeo on Chrome Committed: https://code.google.com/p/dart/source/detail?r=7883

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix line length #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -35 lines)			Patch
	M	tools/testing/perf_testing/dromaeo.html	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	tools/testing/perf_testing/run_perf_tests.py	View	1	4 chunks	+58 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

Emily: will this also require changes to upload scripts? There are some new categories here: ...

8 years, 7 months ago (2012-05-22 22:29:18 UTC) #2

Emily Fortuna

lgtm with comment. Agreed that subclassing should not have been that messy. Perhaps a refactoring ...

8 years, 7 months ago (2012-05-22 22:40:26 UTC) #3

vsm

8 years, 7 months ago (2012-05-22 23:05:06 UTC) #4

Thanks, landed.

https://chromiumcodereview.appspot.com/10408075/diff/1/tools/testing/perf_tes...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/10408075/diff/1/tools/testing/perf_tes...
tools/testing/perf_testing/run_perf_tests.py:857: self.plot_avg_perf('3' +
png_filename, ['chrome', 'dartium'], ['js', 'frog_dom', 'frog_html'])
On 2012/05/22 22:40:27, Emily Fortuna wrote:
> 80 char here and below

Done.

Expand Messages | Collapse Messages