Issue 10408048: Avoid redundant pop/push before Throw/ReThrow in the flow-graph compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408048: Avoid redundant pop/push before Throw/ReThrow in the flow-graph compiler. (Closed)

Created:
8 years, 7 months ago by Florian Schneider

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Avoid redundant pop/push before Throw/ReThrow in the flow-graph compiler. Since the runtime call expects its arguments on the stack, we can just push them in the same way we do in other places. The current code already assumes that the arguments are pushed in the correct order. Committed: https://code.google.com/p/dart/source/detail?r=7831

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	vm/flow_graph_compiler_x64.cc	View		2 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages