Issue 10407099: Generate dart2js versions of Dromaeo

Issue 10407099: Generate dart2js versions of Dromaeo (Closed)

Created:
8 years, 7 months ago by vsm

Modified:
8 years, 7 months ago

Reviewers:
Emily Fortuna, sra

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Generate dart2js versions of Dromaeo Note, this only generates dart2js versions and enables running them in the browser. Before enabling dart2js in the perf script, I need to debug it. The dart2js tests currently hang. Committed: https://code.google.com/p/dart/source/detail?r=7875

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -109 lines)			Patch
M	samples/third_party/dromaeo/README	View	1	1 chunk	+9 lines, -5 lines	0 comments	Download
M	samples/third_party/dromaeo/Suites.dart	View		3 chunks	+19 lines, -17 lines	0 comments	Download
A +	samples/third_party/dromaeo/generate_dart2js_tests.py	View		4 chunks	+20 lines, -12 lines	0 comments	Download
D	samples/third_party/dromaeo/generate_frog_tests.py	View		1 chunk	+0 lines, -73 lines	0 comments	Download
M	tools/testing/perf_testing/run_perf_tests.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm with comments https://chromiumcodereview.appspot.com/10407099/diff/1/samples/third_party/dromaeo/README File samples/third_party/dromaeo/README (right): https://chromiumcodereview.appspot.com/10407099/diff/1/samples/third_party/dromaeo/README#newcode5 samples/third_party/dromaeo/README:5: (1) Execute python ./generate_dart2js_tests.py to create ...

8 years, 7 months ago (2012-05-22 18:31:31 UTC) #2

vsm

8 years, 7 months ago (2012-05-22 20:15:37 UTC) #3

thanks, landed

https://chromiumcodereview.appspot.com/10407099/diff/1/samples/third_party/dr...
File samples/third_party/dromaeo/README (right):

https://chromiumcodereview.appspot.com/10407099/diff/1/samples/third_party/dr...
samples/third_party/dromaeo/README:5: (1) Execute python
./generate_dart2js_tests.py to create frog variants.
On 2012/05/22 18:31:32, Emily Fortuna wrote:
> "to create frog and dart2js variants"

Done.

https://chromiumcodereview.appspot.com/10407099/diff/1/samples/third_party/dr...
samples/third_party/dromaeo/README:8: (3) Alternatively, use a standard browser
to open index-js.html?js|frog in this directory.
On 2012/05/22 18:31:32, Emily Fortuna wrote:
> index-js.html?js|frog|dart2js

Done.

https://chromiumcodereview.appspot.com/10407099/diff/1/samples/third_party/dr...
File samples/third_party/dromaeo/Suites.dart (left):

https://chromiumcodereview.appspot.com/10407099/diff/1/samples/third_party/dr...
samples/third_party/dromaeo/Suites.dart:102: add('dart:html idiomatic',
_htmlPath, ['dart', 'htmlidiomatic']);
Should only appear on the page and nowhere else.

On 2012/05/22 18:31:32, Emily Fortuna wrote:
> I'm assuming it's okay that the name is now "dart:htmlidiomatic" (whitespace
> removal) in the new version?

Expand Messages | Collapse Messages