Add --package-root option to the compiler.

Add --package-root option to the compiler.

Committed: https://code.google.com/p/dart/source/detail?r=7849

[ahe, 2012-05-22 11:42:49]

This is completely untested. We need to find a way to test this kind of stuff.

I guess it could be done with VMOptions, but I really would prefer if we keep
out of that mess. The VMOptions require the use of the --ignore-unrecognized
options and in my opinion, that flag makes it impossible to test command line
options.

PS: @bob: I still plan to switch to your args library, so please don't get
depressed when you are reminded of my option parsing hack :-)

https://chromiumcodereview.appspot.com/10407092/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/dart2js.dart (right):

https://chromiumcodereview.appspot.com/10407092/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/dart2js.dart:264: --output-type=dart
@anton: I decided to simplify this. We only recognize this specific string
anyways.

A related note, I think we want to change line 246 when your work is complete.

[ahe, 2012-05-22 12:49:19]

Thank you, Kasper.

(Kasper gave me an LGTM by replying by mail, not the web interface)

Also, I have filed a bug to track adding a test:
http://code.google.com/p/dart/issues/detail?id=3170

Bill and I discussed how to test this, and we think we have a strategy. I have
higher priorities right now (the resolution-base tree shaker), and should be
able to return to this when I'm done with the shaker. Unless I forget, in which
case I always appreciate a gentle reminder ;-)

[Bob Nystrom, 2012-05-22 17:24:48]

On 2012/05/22 11:42:49, ahe wrote:
> This is completely untested. We need to find a way to test this kind of stuff.
> 
> I guess it could be done with VMOptions, but I really would prefer if we keep
> out of that mess. The VMOptions require the use of the --ignore-unrecognized
> options and in my opinion, that flag makes it impossible to test command line
> options.
> 
> PS: @bob: I still plan to switch to your args library, so please don't get
> depressed when you are reminded of my option parsing hack :-)

There's too much free froyo in the Seattle office for me to ever get depressed,
but I appreciate this. :)