Issue 10407042: spawnUri. Take two. This time I'll wait for Anton before committing :-).

Issue 10407042: spawnUri. Take two. This time I'll wait for Anton before committing :-). (Closed)

Created:
8 years, 7 months ago by turnidge

Modified:
8 years, 7 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

spawnUri. Take two. This time I'll wait for Anton before committing :-). See original change 7756 for description. Committed: https://code.google.com/p/dart/source/detail?r=7917

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+566 lines, -348 lines)			Patch
M	runtime/bin/builtin.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/bin/builtin.dart	View	1	4 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/bin/dartutils.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View	1	4 chunks	+5 lines, -11 lines	0 comments	Download
M	runtime/bin/main.cc	View	1	15 chunks	+121 lines, -60 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1	6 chunks	+82 lines, -22 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	1	9 chunks	+173 lines, -81 lines	0 comments	Download
M	runtime/lib/isolate.dart	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/benchmark_test.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/benchmark_test.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	8 chunks	+60 lines, -18 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1	26 chunks	+63 lines, -76 lines	0 comments	Download
M	runtime/vm/object.h	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	3 chunks	+0 lines, -23 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	6 chunks	+20 lines, -15 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/unit_test.h	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/unit_test.cc	View	1	4 chunks	+6 lines, -7 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
A +	tests/isolate/v2_spawn_uri_vm_negative_test.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tests/isolate/v2_spawn_uri_vm_test.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

turnidge

8 years, 7 months ago (2012-05-18 18:39:25 UTC) #1

In a spurt of thoughtlessness, I committed the spawnUri change, forgettting that
I needed to coordinate the landing.  I've uploaded this CL for Anton to patch
in.

It's already been reviewed in a previous life...

Expand Messages | Collapse Messages