Add IR printing into a supplied buffer.

Add IR printing into a supplied buffer and formatted comments on x64.

This change refactors printing function for instructions
so that they can be used for different purposes like
printing to stdout (what FlowGraphPrinter currently does),
creating code comments for the disassembler, or in the future
dumping the IR into a file.

I added an abstract interface to iterate over the inputs
 of an computation: InputCount and InputAt. This is only
 an intermediate step likely to change in the future. For
 that I had to bring back the [] operator for zero-operand
 instructions.
Committed: https://code.google.com/p/dart/source/detail?r=7731

[srdjan, 2012-05-17 22:59:22]

http://codereview.chromium.org/10407031/diff/1/vm/flow_graph_builder.h
File vm/flow_graph_builder.h (right):

http://codereview.chromium.org/10407031/diff/1/vm/flow_graph_builder.h#newcode28
vm/flow_graph_builder.h:28: return &postorder_block_entries_;
Why not const reference result (and make the getter const again).

http://codereview.chromium.org/10407031/diff/1/vm/il_printer.h
File vm/il_printer.h (right):

http://codereview.chromium.org/10407031/diff/1/vm/il_printer.h#newcode19
vm/il_printer.h:19: void Print(const char* format, ...) {
Move the code into .cc

http://codereview.chromium.org/10407031/diff/1/vm/il_printer.h#newcode24
vm/il_printer.h:24: int written = OS::VSNPrint(buffer_ + position_, available,
format, args);
intptr_t

http://codereview.chromium.org/10407031/diff/1/vm/il_printer.h#newcode25
vm/il_printer.h:25: if (written >= 0) position_ += (available <= written) ?
available : written;
Use { }

http://codereview.chromium.org/10407031/diff/1/vm/il_printer.h#newcode32
vm/il_printer.h:32: int size_;
make size intptr_t

http://codereview.chromium.org/10407031/diff/1/vm/intermediate_language.h
File vm/intermediate_language.h (right):

http://codereview.chromium.org/10407031/diff/1/vm/intermediate_language.h#new...
vm/intermediate_language.h:95: virtual Value* InputAt(intptr_t i) = 0;
const (and in all overriden methods)

http://codereview.chromium.org/10407031/diff/1/vm/intermediate_language.h#new...
vm/intermediate_language.h:106: virtual void PrintOperandsTo(BufferFormatter*
f);
Can they both be const?

http://codereview.chromium.org/10407031/diff/1/vm/intermediate_language.h#new...
vm/intermediate_language.h:1362: void set_block_id(intptr_t number) { block_id_
= number; }
intptr_t value

http://codereview.chromium.org/10407031/diff/1/vm/intermediate_language.h#new...
vm/intermediate_language.h:1372: FlowGraphBuilder* builder,
It seems that you can revert this change and pass preorder and postorder instead
of FlowGraphBuilder.

[Florian Schneider, 2012-05-18 00:28:38]

Addressed feedback and added EmitComment to the compiler.

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/flow_graph_builder.h
File vm/flow_graph_builder.h (right):

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/flow_graph_builder....
vm/flow_graph_builder.h:28: return &postorder_block_entries_;
On 2012/05/17 22:59:22, srdjan wrote:
> Why not const reference result (and make the getter const again).

Done.

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/il_printer.h
File vm/il_printer.h (right):

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/il_printer.h#newcode19
vm/il_printer.h:19: void Print(const char* format, ...) {
On 2012/05/17 22:59:22, srdjan wrote:
> Move the code into .cc

Done.

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/il_printer.h#newcode25
vm/il_printer.h:25: if (written >= 0) position_ += (available <= written) ?
available : written;
On 2012/05/17 22:59:22, srdjan wrote:
> Use { }

Done.

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/il_printer.h#newcode32
vm/il_printer.h:32: int size_;
On 2012/05/17 22:59:22, srdjan wrote:
> make size intptr_t

Done.

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/intermediate_langua...
File vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:95: virtual Value* InputAt(intptr_t i) = 0;
On 2012/05/17 22:59:22, srdjan wrote:
> const (and in all overriden methods)

Done.

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:106: virtual void PrintOperandsTo(BufferFormatter*
f);
On 2012/05/17 22:59:22, srdjan wrote:
> Can they both be const?

Done.

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:1362: void set_block_id(intptr_t number) { block_id_
= number; }
On 2012/05/17 22:59:22, srdjan wrote:
> intptr_t value

Done.

https://chromiumcodereview.appspot.com/10407031/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:1372: FlowGraphBuilder* builder,
On 2012/05/17 22:59:22, srdjan wrote:
> It seems that you can revert this change and pass preorder and postorder
instead
> of FlowGraphBuilder.

Done.

[srdjan, 2012-05-18 00:51:34]

LGTM

http://codereview.chromium.org/10407031/diff/2002/vm/il_printer.h
File vm/il_printer.h (right):

http://codereview.chromium.org/10407031/diff/2002/vm/il_printer.h#newcode24
vm/il_printer.h:24: intptr_t size_;
Add DISALLOW_xxxxx

http://codereview.chromium.org/10407031/diff/2002/vm/il_printer.h#newcode24
vm/il_printer.h:24: intptr_t size_;
size_ is const?

[Florian Schneider, 2012-05-18 01:04:37]

https://chromiumcodereview.appspot.com/10407031/diff/2002/vm/il_printer.h
File vm/il_printer.h (right):

https://chromiumcodereview.appspot.com/10407031/diff/2002/vm/il_printer.h#new...
vm/il_printer.h:24: intptr_t size_;
On 2012/05/18 00:51:34, srdjan wrote:
> size_ is const?

Done.

https://chromiumcodereview.appspot.com/10407031/diff/2002/vm/il_printer.h#new...
vm/il_printer.h:24: intptr_t size_;
On 2012/05/18 00:51:34, srdjan wrote:
> Add DISALLOW_xxxxx

Done.