CTX and TMP registers may not be allocated.

CTX and TMP registers may not be allocated.
Committed: https://code.google.com/p/dart/source/detail?r=7888

[Florian Schneider, 2012-05-22 23:21:35]

LGTM.

[Vyacheslav Egorov (Google), 2012-05-22 23:25:23]

dbc

https://chromiumcodereview.appspot.com/10399136/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_x64.cc (left):

https://chromiumcodereview.appspot.com/10399136/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_x64.cc:61: summary->set_in(0,
Location::RegisterLocation(CTX));
I don't think this change is necessary. 

This is not a register allocated register, this is known fixed register.

https://chromiumcodereview.appspot.com/10399136/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_x64.cc:68: ASSERT(locs()->in(0).reg() == CTX);
Ditto.

[srdjan, 2012-05-22 23:45:38]

https://chromiumcodereview.appspot.com/10399136/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_x64.cc (left):

https://chromiumcodereview.appspot.com/10399136/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_x64.cc:61: summary->set_in(0,
Location::RegisterLocation(CTX));
On 2012/05/22 23:25:23, Vyacheslav Egorov (Google) wrote:
> I don't think this change is necessary. 
> 
> This is not a register allocated register, this is known fixed register.

How is it known? The register allocator attempts to allocate any register,
including the one holding context, unless we block it from being allocatable.

[srdjan, 2012-05-22 23:57:20]

https://chromiumcodereview.appspot.com/10399136/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_x64.cc (left):

https://chromiumcodereview.appspot.com/10399136/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_x64.cc:61: summary->set_in(0,
Location::RegisterLocation(CTX));
On 2012/05/22 23:45:38, srdjan wrote:
> On 2012/05/22 23:25:23, Vyacheslav Egorov (Google) wrote:
> > I don't think this change is necessary. 
> > 
> > This is not a register allocated register, this is known fixed register.
> 
> How is it known? The register allocator attempts to allocate any register,
> including the one holding context, unless we block it from being allocatable.

Discussed offline and  reverted the changes here by moving the blocking of
registers after the input registers locking and before allocating a register.