Issue 10399010: Fixed breakage in template utility now that statics aren't inherited.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399010: Fixed breakage in template utility now that statics aren't inherited. (Closed)

Created:
8 years, 7 months ago by terry

Modified:
8 years, 7 months ago

Reviewers:
jacob314, Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixed breakage in template utility now that statics aren't inherited. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7632

Patch Set 1 #

Patch Set 2 : Fix to calculator and template UI tests. #

Total comments: 1

Patch Set 3 : Added @ for string interpolation #

Patch Set 4 : Updated readme #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -104 lines)			Patch
M	samples/calculator/README.txt	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	samples/calculator/calculator.dart	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	utils/template/codegen.dart	View		9 chunks	+9 lines, -8 lines	0 comments	Download
M	utils/template/parser.dart	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	utils/template/tokenizer.dart	View		7 chunks	+10 lines, -7 lines	0 comments	Download
M	utils/template/tokenizer_base.dart	View		5 chunks	+7 lines, -6 lines	0 comments	Download
M	utils/template/uitest.dart	View	1 2	11 chunks	+74 lines, -73 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jacob314

8 years, 7 months ago (2012-05-14 19:50:24 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10399010/diff/2001/utils/template/uite...
File utils/template/uitest.dart (right):

https://chromiumcodereview.appspot.com/10399010/diff/2001/utils/template/uite...
utils/template/uitest.dart:112: final String complexTemplate = '''
I think @''' will let you specify a string literal.

Expand Messages | Collapse Messages