Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 10398052: Fix incorrect range check comments in List.*Range methods' documentation. (Closed)

Created:
8 years, 7 months ago by Bill Hesse
Modified:
8 years, 7 months ago
Reviewers:
jjb, Bob Nystrom, kasperl
CC:
reviews_dartlang.org, sethladd, Bob Nystrom
Visibility:
Public.

Description

Fix incorrect range check comments in List.*Range methods' documentation. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7784

Patch Set 1 #

Patch Set 2 : fix typo #

Total comments: 6

Patch Set 3 : Incorporate comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M corelib/src/list.dart View 1 2 3 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
Also changes some stray "array"s to "list"s, and some "this list"s to "the list"s for ...
8 years, 7 months ago (2012-05-16 11:47:53 UTC) #1
Bill Hesse
8 years, 7 months ago (2012-05-16 13:39:49 UTC) #2
Bob Nystrom
https://chromiumcodereview.appspot.com/10398052/diff/1002/corelib/src/list.dart File corelib/src/list.dart (right): https://chromiumcodereview.appspot.com/10398052/diff/1002/corelib/src/list.dart#newcode112 corelib/src/list.dart:112: * Returns a sub list copy of the list, ...
8 years, 7 months ago (2012-05-16 16:22:37 UTC) #3
Bill Hesse
8 years, 7 months ago (2012-05-21 10:26:01 UTC) #4
https://chromiumcodereview.appspot.com/10398052/diff/1002/corelib/src/list.dart
File corelib/src/list.dart (right):

https://chromiumcodereview.appspot.com/10398052/diff/1002/corelib/src/list.da...
corelib/src/list.dart:112: * Returns a sub list copy of the list, from [start]
to
On 2012/05/16 16:22:37, Bob Nystrom wrote:
> "sub" isn't a word (or, at least, not in this context). How about:
> 
> "Returns a new list containing [length] elements from this list starting at
> [start]."

Done.

https://chromiumcodereview.appspot.com/10398052/diff/1002/corelib/src/list.da...
corelib/src/list.dart:123: * from [startFrom], into [:this:], starting at
[start].
On 2012/05/16 16:22:37, Bob Nystrom wrote:
> [:this:] -> this list

Done.

https://chromiumcodereview.appspot.com/10398052/diff/1002/corelib/src/list.da...
corelib/src/list.dart:133: * Removes from the list the range from [start] to
On 2012/05/16 16:22:37, Bob Nystrom wrote:
> "Removes [length] elements from this list, beginning at [start]."

Done.

Powered by Google App Engine
This is Rietveld 408576698