Issue 10398015: Move FlowGraphPrinter to a new file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10398015: Move FlowGraphPrinter to a new file. (Closed)

Created:
8 years, 7 months ago by Florian Schneider

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Move FlowGraphPrinter to a new file. This change is just moving code around. Committed: https://code.google.com/p/dart/source/detail?r=7627

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+450 lines, -422 lines)			Patch
M	vm/flow_graph_builder.cc	View		2 chunks	+1 line, -422 lines	0 comments	Download
A	vm/il_printer.h	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download
A	vm/il_printer.cc	View	1	1 chunk	+397 lines, -0 lines	0 comments	Download
M	vm/vm_sources.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Just a preparation change before adding generation of IR visualizer output.

8 years, 7 months ago (2012-05-14 17:43:12 UTC) #1

srdjan

LGTM https://chromiumcodereview.appspot.com/10398015/diff/1/vm/il_printer.h File vm/il_printer.h (right): https://chromiumcodereview.appspot.com/10398015/diff/1/vm/il_printer.h#newcode8 vm/il_printer.h:8: #include "vm/flow_graph_builder.h" Do you need to import flow_graph_builder.h ...

8 years, 7 months ago (2012-05-14 18:21:16 UTC) #2