Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 10392195: Add support for websocket PING and PONG frames (Closed)

Created:
8 years, 7 months ago by Søren Gjesse
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add support for websocket PING and PONG frames The handling of control frames have been refactored to uniformly hanlde CLOSE, PING and PONG frames. Currently this is not tested as I have bot found a good way to test it yet. It has been somewhat tested with a browser client forcing ping messages from the server and processing the pong responses from the browser. R=ager@google.com, ajohnsen@google.com BUG=none TEST=none Committed: https://code.google.com/p/dart/source/detail?r=7844

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -80 lines) Patch
M runtime/bin/websocket_impl.dart View 1 12 chunks +112 lines, -80 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
8 years, 7 months ago (2012-05-22 08:36:50 UTC) #1
Anders Johnsen
LGTM, however, a bit hard to review. https://chromiumcodereview.appspot.com/10392195/diff/1/runtime/bin/io.dart File runtime/bin/io.dart (right): https://chromiumcodereview.appspot.com/10392195/diff/1/runtime/bin/io.dart#newcode16 runtime/bin/io.dart:16: #import("dart:builtin"); You ...
8 years, 7 months ago (2012-05-22 08:54:34 UTC) #2
Mads Ager (google)
lgtm https://chromiumcodereview.appspot.com/10392195/diff/1/runtime/bin/websocket_impl.dart File runtime/bin/websocket_impl.dart (right): https://chromiumcodereview.appspot.com/10392195/diff/1/runtime/bin/websocket_impl.dart#newcode296 runtime/bin/websocket_impl.dart:296: 2, _controlPayload.length - 2)); Maybe just use four-space ...
8 years, 7 months ago (2012-05-22 09:04:13 UTC) #3
Søren Gjesse
8 years, 7 months ago (2012-05-22 10:34:28 UTC) #4
https://chromiumcodereview.appspot.com/10392195/diff/1/runtime/bin/io.dart
File runtime/bin/io.dart (right):

https://chromiumcodereview.appspot.com/10392195/diff/1/runtime/bin/io.dart#ne...
runtime/bin/io.dart:16: #import("dart:builtin");
On 2012/05/22 08:54:34, ajohnsen wrote:
> You have one guess ^_^

Sorry.

https://chromiumcodereview.appspot.com/10392195/diff/1/runtime/bin/websocket_...
File runtime/bin/websocket_impl.dart (right):

https://chromiumcodereview.appspot.com/10392195/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:250: // Check whether there is any payload. If
not handle callbacks
On 2012/05/22 08:54:34, ajohnsen wrote:
> Weird sentence. 

Rephrased.

https://chromiumcodereview.appspot.com/10392195/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:296: 2, _controlPayload.length - 2));
On 2012/05/22 09:04:13, Mads Ager wrote:
> Maybe just use four-space indentation here. The arguments are currently
aligned
> as arguments to write.

Done.

Powered by Google App Engine
This is Rietveld 408576698