Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10392089: Add a Pub source that checks packages out from Git. (Closed)

Created:
8 years, 7 months ago by nweiz
Modified:
8 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a Pub source that checks packages out from Git. This was submitted as r7623, but was then reverted due to test failures. The new version doesn't depend on Git's output. Committed: https://code.google.com/p/dart/source/detail?r=7629

Patch Set 1 #

Patch Set 2 : Update both RegExps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -49 lines) Patch
A utils/pub/git_source.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M utils/pub/io.dart View 3 chunks +23 lines, -9 lines 0 comments Download
M utils/pub/package.dart View 3 chunks +58 lines, -7 lines 0 comments Download
M utils/pub/packages_dir.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/pub.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M utils/pub/source.dart View 1 chunk +0 lines, -16 lines 0 comments Download
A utils/pub/source_registry.dart View 1 chunk +61 lines, -0 lines 0 comments Download
M utils/pub/system_cache.dart View 3 chunks +9 lines, -3 lines 0 comments Download
M utils/pub/utils.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 1 4 chunks +61 lines, -3 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 5 chunks +50 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
The only change from last time is the RegExp for validating Pub's output for the ...
8 years, 7 months ago (2012-05-14 20:38:26 UTC) #1
Bob Nystrom
8 years, 7 months ago (2012-05-14 21:32:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698