Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 10392078: Report total time for multiphase tests, in test script's --test option, not time of last phase. (Closed)

Created:
8 years, 7 months ago by Bill Hesse
Modified:
8 years, 7 months ago
Reviewers:
ahe, Mads Ager (google)
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Report total time for multiphase tests, in test script's --test option, not time of last phase. BUG= TEST=test.py --time Committed: https://code.google.com/p/dart/source/detail?r=7607

Patch Set 1 #

Patch Set 2 : Also, fix long lines. #

Total comments: 2

Patch Set 3 : Improve long line fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M tools/testing/dart/test_runner.dart View 1 2 6 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
As seen in the following before-and-after comparison, reporting total times for tests helps more in ...
8 years, 7 months ago (2012-05-14 12:15:45 UTC) #1
Mads Ager (google)
lgtm http://codereview.chromium.org/10392078/diff/3/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): http://codereview.chromium.org/10392078/diff/3/tools/testing/dart/test_runner.dart#newcode435 tools/testing/dart/test_runner.dart:435: Cannot have both @static-clean and /// static type ...
8 years, 7 months ago (2012-05-14 12:20:16 UTC) #2
ahe
8 years, 7 months ago (2012-05-14 12:23:26 UTC) #3
LGTM, thank you!

Powered by Google App Engine
This is Rietveld 408576698