Issue 10391171: Remove an unused input operand from ExtractConstructorInstantiator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10391171: Remove an unused input operand from ExtractConstructorInstantiator. (Closed)

Created:
8 years, 7 months ago by Florian Schneider

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Remove an unused input operand from ExtractConstructorInstantiator. The second input is discarded, so we don't need to pass it as input to the computation. The explicit pop in the code generator is replaced by LoadValue. This is a small step in refactoring the flowgraph-based code generator to be shared between multiple backends. Committed: https://code.google.com/p/dart/source/detail?r=7705

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -14 lines)			Patch
M	vm/flow_graph_builder.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	vm/flow_graph_compiler_x64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	vm/il_printer.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	vm/intermediate_language.h	View	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM (CC-ing Regis who may know why we do not need it any longer)

8 years, 7 months ago (2012-05-16 21:54:57 UTC) #2

regis

8 years, 7 months ago (2012-05-17 18:46:44 UTC) #3

On 2012/05/16 21:54:57, srdjan wrote:
> LGTM
> (CC-ing Regis who may know why we do not need it any longer)

LGTM

This is not needed anymore, because this cl started to use locals to pass the
instantiator type arguments and constructor type arguments:
https://chromiumcodereview.appspot.com/10310132
Before that, we needed to pop a value from the stack (discard_value).

Expand Messages | Collapse Messages