Issue 10391135: Re-apply "Fix URL decoding in HTTP library"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10391135: Re-apply "Fix URL decoding in HTTP library" (Closed)

Created:
8 years, 7 months ago by Søren Gjesse

Modified:
8 years, 7 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-apply "Fix URL decoding in HTTP library" Now URL decoding works for non-ASCII URLs and will be UTF-8 decoded. Added an additional import to lib/compiler/implementation/lib/io.dart for the tests to compile with dart2js. TBR=ager@google.com BUG=dart:2902 TEST=tests/standalone/io/url_encoding_test.dart Committed: https://code.google.com/p/dart/source/detail?r=7644

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -32 lines)			Patch
M	lib/compiler/implementation/lib/io.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/http_utils.dart	View	1 chunk	+32 lines, -21 lines	0 comments	Download
M	runtime/bin/io.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/http_date_test.dart	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	tests/standalone/io/url_encoding_test.dart	View	2 chunks	+17 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages