Issue 10391056: - Typed arrays should implement all methods from Collection and List interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10391056: - Typed arrays should implement all methods from Collection and List interfaces. (Closed)

Created:
8 years, 7 months ago by Ivan Posva

Modified:
8 years, 7 months ago

Reviewers:
Anders Johnsen, cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Typed arrays should implement all methods from Collection and List interfaces. Committed: https://code.google.com/p/dart/source/detail?r=7512

Patch Set 1 #

Total comments: 3

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -24 lines)			Patch
	M	runtime/lib/byte_array.dart	View		6 chunks	+123 lines, -24 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, thank you for doing this! https://chromiumcodereview.appspot.com/10391056/diff/1/runtime/lib/byte_array.dart File runtime/lib/byte_array.dart (right): https://chromiumcodereview.appspot.com/10391056/diff/1/runtime/lib/byte_array.dart#newcode255 runtime/lib/byte_array.dart:255: new GrowableObjectArray.withCapacity(length), This ...

8 years, 7 months ago (2012-05-11 08:38:53 UTC) #3

Anders Johnsen

8 years, 7 months ago (2012-05-11 08:52:13 UTC) #4

A quick comment.

https://chromiumcodereview.appspot.com/10391056/diff/1/runtime/lib/byte_array...
File runtime/lib/byte_array.dart (right):

https://chromiumcodereview.appspot.com/10391056/diff/1/runtime/lib/byte_array...
runtime/lib/byte_array.dart:1835: void setRange(int start, int length, List<int>
from, [int startFrom = 0]) {
I was wondering if we should change this to a call to ByteArray._setRange, or if
the Arrays.copy version is optimized for these native types?

Expand Messages | Collapse Messages