Issue 10391037: Fix dealing with incomplete files as the first set of files encountered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10391037: Fix dealing with incomplete files as the first set of files encountered. (Closed)

Created:
8 years, 7 months ago by Emily Fortuna

Modified:
8 years, 7 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix dealing with incomplete files as the first set of files encountered. Committed: https://code.google.com/p/dart/source/detail?r=7477

Patch Set 4 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -15 lines)			Patch
	M	tools/testing/perf_testing/run_perf_tests.py	View	1 2	7 chunks	+29 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

I neglected to change the "open from the "old" dir" in all of our different ...

8 years, 7 months ago (2012-05-09 20:24:13 UTC) #1

vsm

lgtm https://chromiumcodereview.appspot.com/10391037/diff/3001/tools/testing/perf_testing/run_perf_tests.py File tools/testing/perf_testing/run_perf_tests.py (right): https://chromiumcodereview.appspot.com/10391037/diff/3001/tools/testing/perf_testing/run_perf_tests.py#newcode694 tools/testing/perf_testing/run_perf_tests.py:694: file_path = os.path.join(self.test.result_folder_name, afile) Consider refactoring into Processor ...

8 years, 7 months ago (2012-05-09 20:53:11 UTC) #2

Emily Fortuna

8 years, 7 months ago (2012-05-09 20:57:07 UTC) #3

https://chromiumcodereview.appspot.com/10391037/diff/3001/tools/testing/perf_...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/10391037/diff/3001/tools/testing/perf_...
tools/testing/perf_testing/run_perf_tests.py:694: file_path =
os.path.join(self.test.result_folder_name, afile)
On 2012/05/09 20:53:11, vsm wrote:
> Consider refactoring into Processor base class.

Will do!

Expand Messages | Collapse Messages

Issue 10391037: Fix dealing with incomplete files as the first set of files encountered. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages