Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 10389223: Add unittest to apidoc and fix readme. (Closed)

Created:
8 years, 7 months ago by Emily Fortuna
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang), sethladd
Visibility:
Public.

Description

Add unittest to apidoc and fix readme. Committed: https://code.google.com/p/dart/source/detail?r=7779

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M lib/unittest/unittest.dart View 1 chunk +2 lines, -0 lines 2 comments Download
M utils/apidoc/README.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/apidoc/apidoc.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Emily Fortuna
Then maybe you can explain the process of uploading the updated docs to dartlang.org
8 years, 7 months ago (2012-05-18 23:15:01 UTC) #1
Emily Fortuna
+ siggi, to see my change to unittest.dart
8 years, 7 months ago (2012-05-18 23:22:07 UTC) #2
Bob Nystrom
LGTM!
8 years, 7 months ago (2012-05-18 23:24:07 UTC) #3
Bob Nystrom
On 2012/05/18 23:15:01, Emily Fortuna wrote: > Then maybe you can explain the process of ...
8 years, 7 months ago (2012-05-18 23:24:28 UTC) #4
Emily Fortuna
+ seth to update dartlang when we'd like.
8 years, 7 months ago (2012-05-18 23:30:54 UTC) #5
Siggi Cherem (dart-lang)
8 years, 7 months ago (2012-05-18 23:33:32 UTC) #6
lgtm!

https://chromiumcodereview.appspot.com/10389223/diff/7001/lib/unittest/unitte...
File lib/unittest/unittest.dart (right):

https://chromiumcodereview.appspot.com/10389223/diff/7001/lib/unittest/unitte...
lib/unittest/unittest.dart:8: * To import this library, specify the relative
path to lib/unittest.dart.
lib/unittest.dart => lib/unittest/unittest.dart

https://chromiumcodereview.appspot.com/10389223/diff/7001/lib/unittest/unitte...
lib/unittest/unittest.dart:97: * features or fixes to the current spec (e.g. see
dartbug.com/2706).
let's make this url a link.

Powered by Google App Engine
This is Rietveld 408576698