Issue 10389113: Make a single labeled statement hold all its labels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389113: Make a single labeled statement hold all its labels. (Closed)

Created:
8 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 7 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make a single labeled statement hold all its labels. Previously a single labeled statement only held one label, and nested labeled statements was used for multiple labels. Committed: https://code.google.com/p/dart/source/detail?r=7602

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -37 lines)			Patch
M	lib/compiler/implementation/resolver.dart	View	3 chunks	+22 lines, -20 lines	2 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	lib/compiler/implementation/tree/nodes.dart	View	1 chunk	+5 lines, -9 lines	0 comments	Download
M	lib/compiler/implementation/tree/unparser.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://chromiumcodereview.appspot.com/10389113/diff/1/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://chromiumcodereview.appspot.com/10389113/diff/1/lib/compiler/implementation/resolver.dart#newcode479 lib/compiler/implementation/resolver.dart:479: LabeledStatementLabelScope(this.outer, this.labels); My guess is that this scope ...

8 years, 7 months ago (2012-05-14 10:11:40 UTC) #2

Lasse Reichstein Nielsen

8 years, 7 months ago (2012-05-14 10:44:59 UTC) #3

https://chromiumcodereview.appspot.com/10389113/diff/1/lib/compiler/implement...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10389113/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:479:
LabeledStatementLabelScope(this.outer, this.labels);
True. It's probably slower if there is only one label, which is the "common"
case.
If it turns out to be a measurable problem, we can introduce a simpler scope for
that case.

Expand Messages | Collapse Messages