Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 10389090: Increase thread stack size on Mac in debug mode. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Increase thread stack size on Mac in debug mode. After changing dart:io to use Futures the debug Mac build hit the stack limit during snapshot reading. Landing this to unbreak the build. R=sgjesse@google.com,asiva@google.com,iposva@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/platform/thread_macos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
TBR
8 years, 7 months ago (2012-05-11 07:12:06 UTC) #1
Mads Ager (google)
Interestingly, the stack size on Linux is 1024kb in both release and debug builds.
8 years, 7 months ago (2012-05-11 07:12:50 UTC) #2
Søren Gjesse
8 years, 7 months ago (2012-05-11 07:57:49 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698