Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 10389074: Cache unresolved units separately from libraries (Closed)

Created:
8 years, 7 months ago by danrubel
Modified:
8 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cache unresolved units separately from libraries Committed: https://code.google.com/p/dart/source/detail?r=7527

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -57 lines) Patch
M compiler/java/com/google/dart/compiler/DartCompiler.java View 5 chunks +19 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java View 3 chunks +10 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/Context.java View 3 chunks +29 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/Library.java View 7 chunks +25 lines, -23 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/ParseFileTask.java View 1 chunk +15 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/ParseLibraryFileEvent.java View 2 chunks +4 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/ParseLibraryFileTask.java View 3 chunks +26 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/ParseLibraryTask.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/ResolveLibraryTask.java View 4 chunks +5 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danrubel
* cache unresolved units separately * update DartC to find parsed units during resolution * ...
8 years, 7 months ago (2012-05-10 20:21:26 UTC) #1
scheglov
8 years, 7 months ago (2012-05-10 22:16:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698