Issue 10388085: Merge wrapping system into native system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10388085: Merge wrapping system into native system. (Closed)

Created:
8 years, 7 months ago by podivilov

Modified:
8 years, 7 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Merge wrapping system into native system. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=7546

Patch Set 2 : . #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+288 lines, -566 lines)			Patch
M	lib/dom/scripts/dartdomgenerator.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/scripts/dartgenerator.py	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View	1	8 chunks	+287 lines, -8 lines	0 comments	Download
D	lib/dom/scripts/systemwrapping.py	View		1 chunk	+0 lines, -546 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

LGTM w/ comment addressed https://chromiumcodereview.appspot.com/10388085/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10388085/diff/1/lib/dom/scripts/systemnative.py#newcode606 lib/dom/scripts/systemnative.py:606: dart_declaration = '%s operator[](int index)' ...

8 years, 7 months ago (2012-05-11 11:54:32 UTC) #2

podivilov

8 years, 7 months ago (2012-05-11 14:18:38 UTC) #3

https://chromiumcodereview.appspot.com/10388085/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10388085/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:606: dart_declaration = '%s operator[](int
index)' % dart_element_type
On 2012/05/11 11:54:32, antonmuhin wrote:
> let's not inline _EmitNativeIndex{G,S}etter

Done.

Expand Messages | Collapse Messages

Issue 10388085: Merge wrapping system into native system. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages