Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 10388069: Don't emit dangling comma in object literal. (Closed)

Created:
8 years, 7 months ago by floitsch
Modified:
8 years, 7 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

Don't emit dangling comma in object literal. Committed: https://code.google.com/p/dart/source/detail?r=7488

Patch Set 1 #

Patch Set 2 : Avoid {\n\n} #

Patch Set 3 : Fix typo and more cosmetic changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -3 lines) Patch
A frog/tests/leg/class_codegen2_test.dart View 1 chunk +87 lines, -0 lines 0 comments Download
M lib/compiler/implementation/emitter.dart View 1 2 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
8 years, 7 months ago (2012-05-10 12:55:34 UTC) #1
floitsch
minor cosmetic change (avoid {\n\n}).
8 years, 7 months ago (2012-05-10 13:20:01 UTC) #2
ngeoffray
8 years, 7 months ago (2012-05-10 13:35:34 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698