Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 10388068: After bit-operation fixes the crypto library works with dart2js. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)
Modified:
8 years, 7 months ago
Reviewers:
Søren Gjesse, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

After bit-operation fixes the crypto library works with dart2js. Only change is to avoid remaining issue that (8 >> 32) is 8 with dart2js at this point. We restrict the length of the message to "2^32 - 1" bits which. R=sgjesse@google.com,floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M lib/crypto/hash_utils.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 7 months ago (2012-05-11 07:42:42 UTC) #1
Søren Gjesse
8 years, 7 months ago (2012-05-11 07:57:12 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698