Issue 10387186: Reapply this reverted change:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10387186: Reapply this reverted change: (Closed)

Created:
8 years, 7 months ago by regis

Modified:
8 years, 7 months ago

Reviewers:
vsm, Anton Muhin, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Reapply this reverted change: Implement updated method overriding rules (issue 2943). Committed: https://code.google.com/p/dart/source/detail?r=7749

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -16 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	4 chunks	+18 lines, -8 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	tests/language/method_override2_test.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

regis

Anton or Vijay, Please, approve once Dartium is fixed. Thanks, Regis

8 years, 7 months ago (2012-05-18 01:16:28 UTC) #1

Dartium is hopefully fixed, you're good to go!

lgtm