Issue 10387082: Fix URL decoding in HTTP library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10387082: Fix URL decoding in HTTP library (Closed)

Created:
8 years, 7 months ago by Søren Gjesse

Modified:
8 years, 7 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix URL decoding in HTTP library Now URL decoding works for non-ASCII URLs and will be UTF-8 decoded. R=ager@google.com BUG=dart:2902 TEST=tests/standalone/io/url_encoding_test.dart Committed: https://code.google.com/p/dart/source/detail?r=7599

Patch Set 1 #

Patch Set 2 : Minor fix #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -32 lines)			Patch
M	runtime/bin/http_utils.dart	View		1 chunk	+33 lines, -21 lines	2 comments	Download
M	runtime/bin/io.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/http_date_test.dart	View		1 chunk	+8 lines, -6 lines	0 comments	Download
M	tests/standalone/io/url_encoding_test.dart	View		2 chunks	+17 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM https://chromiumcodereview.appspot.com/10387082/diff/3001/runtime/bin/http_utils.dart File runtime/bin/http_utils.dart (right): https://chromiumcodereview.appspot.com/10387082/diff/3001/runtime/bin/http_utils.dart#newcode7 runtime/bin/http_utils.dart:7: // First check the string for any encoding ...

8 years, 7 months ago (2012-05-14 08:19:26 UTC) #2

Søren Gjesse

8 years, 7 months ago (2012-05-14 09:54:26 UTC) #3

https://chromiumcodereview.appspot.com/10387082/diff/3001/runtime/bin/http_ut...
File runtime/bin/http_utils.dart (right):

https://chromiumcodereview.appspot.com/10387082/diff/3001/runtime/bin/http_ut...
runtime/bin/http_utils.dart:7: // First check the string for any encoding - if
not no decoding is
On 2012/05/14 08:19:26, Mads Ager wrote:
> Remove the ' - if not ...' part?

Done.

Expand Messages | Collapse Messages