Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 10387019: Add gyp build for sample-extension. (Closed)

Created:
8 years, 7 months ago by Bill Hesse
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add gyp build for sample-extension. Add Visual Studio project file for samples/sample_extension. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7412

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix whitespace, remove empty variables section of sample_extension.gypi. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M dart.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/dart-runtime.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A samples/sample_extension/sample_extension.gypi View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
http://codereview.chromium.org/10387019/diff/1/samples/sample_extension/sample_extension.gypi File samples/sample_extension/sample_extension.gypi (right): http://codereview.chromium.org/10387019/diff/1/samples/sample_extension/sample_extension.gypi#newcode7 samples/sample_extension/sample_extension.gypi:7: }, Remove the variables section.
8 years, 7 months ago (2012-05-08 11:17:01 UTC) #1
Mads Ager (google)
lgtm http://codereview.chromium.org/10387019/diff/1/samples/sample_extension/sample_extension.gypi File samples/sample_extension/sample_extension.gypi (right): http://codereview.chromium.org/10387019/diff/1/samples/sample_extension/sample_extension.gypi#newcode7 samples/sample_extension/sample_extension.gypi:7: }, On 2012/05/08 11:17:01, Bill Hesse wrote: > ...
8 years, 7 months ago (2012-05-08 11:23:30 UTC) #2
siva
Shouldn't this dependency be added to the dart SDK build rather than dart runtime build.
8 years, 7 months ago (2012-05-08 17:18:51 UTC) #3
Bill Hesse
On 2012/05/08 17:18:51, asiva wrote: > Shouldn't this dependency be added to the dart SDK ...
8 years, 7 months ago (2012-05-08 20:16:44 UTC) #4
Ivan Posva
8 years, 7 months ago (2012-05-09 00:12:05 UTC) #5
When changing the runtime build please talk to Siva or me first. We need to
understand why this dependency is being added.

Thanks,
-Ivan

Powered by Google App Engine
This is Rietveld 408576698