Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 10386161: Start compiler refactoring to support more than a single backend. (Closed)

Created:
8 years, 7 months ago by Anton Muhin
Modified:
8 years, 7 months ago
Reviewers:
ahe, floitsch, ngeoffray, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -94 lines) Patch
M lib/compiler/implementation/compiler.dart View 6 chunks +52 lines, -28 lines 0 comments Download
M lib/compiler/implementation/emitter.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M lib/compiler/implementation/native_emitter.dart View 6 chunks +8 lines, -6 lines 0 comments Download
M lib/compiler/implementation/native_handler.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 5 chunks +14 lines, -11 lines 0 comments Download
M lib/compiler/implementation/ssa/closure.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 11 chunks +20 lines, -17 lines 0 comments Download
M lib/compiler/implementation/ssa/optimize.dart View 9 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Anton Muhin
Forgot to fix another reference to Emitter instead of CodeEmitterTask. Offended tests pass, landing it ...
8 years, 7 months ago (2012-05-16 06:09:49 UTC) #1
floitsch
8 years, 7 months ago (2012-05-16 10:47:44 UTC) #2
Still LGTM.

Powered by Google App Engine
This is Rietveld 408576698