Issue 10386121: Initial new file FileUtils with a single public static method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386121: Initial new file FileUtils with a single public static method. (Closed)

Created:
8 years, 7 months ago by jwren

Modified:
8 years, 7 months ago

Reviewers:
scheglov, danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Initial new file FileUtils with a single public static method. Committed: https://code.google.com/p/dart/source/detail?r=7625

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -0 lines)			Patch
	A	compiler/java/com/google/dart/compiler/util/apache/FileUtils.java	View	1 2	1 chunk	+64 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM in general. Just one thing that I've forgot initially. Add following to the JavaDoc. ...

8 years, 7 months ago (2012-05-14 20:09:07 UTC) #2

jwren

8 years, 7 months ago (2012-05-14 20:10:52 UTC) #3

Thanks, I'll make this change before I land the file.

On 2012/05/14 20:09:07, scheglov wrote:
> LGTM in general.
> Just one thing that I've forgot initially.
> Add following to the JavaDoc.
> According to license we have to provide notice that code was modified.
> 
> 
>  * <p>
>  * NOTICE: This file is modified copy of its original Apache library.
>  * It was moved to the different package, and changed to reduce number of
> dependencies.

Expand Messages | Collapse Messages