Implement spawnUri from dart:isolate. This function allows us to

Implement spawnUri from dart:isolate.  This function allows us to
launch an isolate running a different script.  Finally.

Reviewers: This isn't as hard to review as it looks.  Dive right in!

Siggi: Take a look at my test status file changes and make sure I'm
excluding the right stuff.

Much of the churn in the CL comes from moving ownership of the
import_map.  It used to be set per-library and is now set per-isolate.
This caused a lot of superficial diffs.

DART EMBEDDING API CHANGES:

- Dart_IsolateCreateCallback now takes a script_uri and main argument
  instead of a name_prefix argument.  The script_uri argument allows
  the callback to launch different scripts.  The main argument is used
  in creating the isolate debug name.

- Dart_CreateIsolate now takes script_uri and main arguments.  These
  are used to build the isolate's debug name.

- Dart_LibraryTagHandler, Dart_LoadScript, and Dart_LoadLibrary no
  longer take an import_map.

- Added Dart_SetImportMap.

- Added Dart_RootLibrary to provide access to the root library for the
  current isolate.

OTHER STUFF

Add a couple of tests for spawnUri -- the existing tests assume that
scripts end in a .js suffix which isn't going to work out for us.

Changed how the debug name for isolates get built a bit.

Refactored bin/main.cc a bit.  Fixed some problems with error handling
while creating isolates.

Minor refactoring in builtin.dart to always pass is_windows rather
than relying on it being squirreled away.
Committed: https://code.google.com/p/dart/source/detail?r=7756

[Siggi Cherem (dart-lang), 2012-05-14 22:08:38]

https://chromiumcodereview.appspot.com/10386107/diff/3038/tests/isolate/isola...
File tests/isolate/isolate.status (right):

https://chromiumcodereview.appspot.com/10386107/diff/3038/tests/isolate/isola...
tests/isolate/isolate.status:16: v2_spawn_uri_vm_test: Fail # not implemented
here and below the comment should probably be like you had above (test uses a
".dart" suffix, but frog/dart2js expect a ".js" suffix?)

[turnidge, 2012-05-14 22:18:31]

Hi guys,

This is the new CL for my spawnUri change.  Not sure what happened...

https://chromiumcodereview.appspot.com/10386107/diff/3038/tests/isolate/isola...
File tests/isolate/isolate.status (right):

https://chromiumcodereview.appspot.com/10386107/diff/3038/tests/isolate/isola...
tests/isolate/isolate.status:16: v2_spawn_uri_vm_test: Fail # not implemented
On 2012/05/14 22:08:38, sigmund wrote:
> here and below the comment should probably be like you had above (test uses a
> ".dart" suffix, but frog/dart2js expect a ".js" suffix?)

Done.

[Ivan Posva, 2012-05-15 00:04:46]

LGTM with comments.

-Ivan

https://chromiumcodereview.appspot.com/10386107/diff/3038/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

https://chromiumcodereview.appspot.com/10386107/diff/3038/runtime/lib/isolate...
runtime/lib/isolate.cc:502: ASSERT(callback);
I am pretty sure callback is not a boolean value. Can you please change this to
callback != NULL? Thanks!

https://chromiumcodereview.appspot.com/10386107/diff/3038/runtime/lib/isolate...
File runtime/lib/isolate.dart (right):

https://chromiumcodereview.appspot.com/10386107/diff/3038/runtime/lib/isolate...
runtime/lib/isolate.dart:133: _getPortInternal() native
"isolate_getPortInternal";
I must have missed this previously. Is there any reason why we went away from
the convention of "Class_method" for these native entry points?

[turnidge, 2012-05-15 17:47:38]

Ivan,

Addressed these two comments plus the comment from the older CL.  I factored out
FilePathFromUri and shared it in the tagmapper and the other spot.

Todd

https://chromiumcodereview.appspot.com/10386107/diff/3038/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

https://chromiumcodereview.appspot.com/10386107/diff/3038/runtime/lib/isolate...
runtime/lib/isolate.cc:502: ASSERT(callback);
On 2012/05/15 00:04:46, Ivan Posva wrote:
> I am pretty sure callback is not a boolean value. Can you please change this
to
> callback != NULL? Thanks!

Done.

https://chromiumcodereview.appspot.com/10386107/diff/3038/runtime/lib/isolate...
File runtime/lib/isolate.dart (right):

https://chromiumcodereview.appspot.com/10386107/diff/3038/runtime/lib/isolate...
runtime/lib/isolate.dart:133: _getPortInternal() native
"isolate_getPortInternal";
On 2012/05/15 00:04:46, Ivan Posva wrote:
> I must have missed this previously. Is there any reason why we went away from
> the convention of "Class_method" for these native entry points?

getPortInternal is a top-level function in the library "dart:isolate".  There
isn't a class name to use here...

[Anton Muhin, 2012-05-15 19:06:43]

LGTM.

Please, let me know when you're about to launch it so I can adjust bindings.

https://chromiumcodereview.appspot.com/10386107/diff/5064/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

https://chromiumcodereview.appspot.com/10386107/diff/5064/runtime/lib/isolate...
runtime/lib/isolate.cc:276: const char* root_script =
GetRootScriptUri(preserved_isolate);
root_script_uri?