Issue 10386088: Add a TypeResolver to resolve type annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386088: Add a TypeResolver to resolve type annotations. (Closed)

Created:
8 years, 7 months ago by karlklose

Modified:
8 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a TypeResolver to resolve type annotations. Committed: https://code.google.com/p/dart/source/detail?r=8324

Patch Set 1 : #

Total comments: 4

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -69 lines)			Patch
	M	lib/compiler/implementation/resolver.dart	View		3 chunks	+109 lines, -69 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10386088/diff/5001/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://chromiumcodereview.appspot.com/10386088/diff/5001/lib/compiler/implementation/resolver.dart#newcode628 lib/compiler/implementation/resolver.dart:628: onFailure = (n, k, [arguments]) => {}; Returns ...

8 years, 6 months ago (2012-06-06 11:12:26 UTC) #2

karlklose

8 years, 6 months ago (2012-06-06 11:43:37 UTC) #3

Thanks Nicolas.

https://chromiumcodereview.appspot.com/10386088/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10386088/diff/5001/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:628: onFailure = (n, k, [arguments])
=> {};
On 2012/06/06 11:12:26, ngeoffray wrote:
> Returns a map? :-)

Done.

https://chromiumcodereview.appspot.com/10386088/diff/5001/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:631: whenResolved = (n, t) => {};
On 2012/06/06 11:12:26, ngeoffray wrote:
> ditto

Done.

Expand Messages | Collapse Messages